PMD Results

The following document contains the results of PMD

Files

net/sourceforge/servletspy/ctx/Context.java

ViolationLine
Found non-transient, non-static member. Please mark as transient or provide accessors.63
Found non-transient, non-static member. Please mark as transient or provide accessors.69
Found non-transient, non-static member. Please mark as transient or provide accessors.75
Found non-transient, non-static member. Please mark as transient or provide accessors.78

net/sourceforge/servletspy/util/ClassUtil.java

ViolationLine
Document empty constructor32 - 33

net/sourceforge/servletspy/Spy.java

ViolationLine
Document empty constructor46 - 47
Consider simply returning the value vs storing it in local variable 'node'83

net/sourceforge/servletspy/About.java

ViolationLine
Private field could be made final. It is only initialized in the declaration or constructor.43
Found non-transient, non-static member. Please mark as transient or provide accessors.43

net/sourceforge/servletspy/IContextHandler.java

ViolationLine
A signature (constructor or method) shouldn't have Exception in throws declaration45

net/sourceforge/servletspy/config/ContextHandlerFactory.java

ViolationLine
Possible unsafe assignment to a non-final static field in a constructor.38
Found non-transient, non-static member. Please mark as transient or provide accessors.48
Avoid throwing null pointer exceptions52
Avoid empty catch blocks80 - 82

net/sourceforge/servletspy/config/Handler.java

ViolationLine
Found non-transient, non-static member. Please mark as transient or provide accessors.29
Found non-transient, non-static member. Please mark as transient or provide accessors.31
Document empty constructor33 - 34

net/sourceforge/servletspy/config/Param.java

ViolationLine
Avoid protected fields in a final class. Change to private or package access.29
Found non-transient, non-static member. Please mark as transient or provide accessors.29
Avoid protected fields in a final class. Change to private or package access.31
Found non-transient, non-static member. Please mark as transient or provide accessors.31
Document empty constructor33 - 34

net/sourceforge/servletspy/config/Loader.java

ViolationLine
Found non-transient, non-static member. Please mark as transient or provide accessors.48
Use block level rather than method level synchronization50 - 73
Avoid instantiation through private constructors from outside of the constructor's class.59 - 60
Avoid instantiation through private constructors from outside of the constructor's class.71
Use block level rather than method level synchronization75 - 81

net/sourceforge/servletspy/config/ServletSpy.java

ViolationLine
Avoid protected fields in a final class. Change to private or package access.38
Found non-transient, non-static member. Please mark as transient or provide accessors.38
Avoid protected fields in a final class. Change to private or package access.40
Found non-transient, non-static member. Please mark as transient or provide accessors.40
Avoid throwing null pointer exceptions45
Document empty constructor67 - 68

net/sourceforge/servletspy/Node.java

ViolationLine
Found non-transient, non-static member. Please mark as transient or provide accessors.41
Found non-transient, non-static member. Please mark as transient or provide accessors.47
Found non-transient, non-static member. Please mark as transient or provide accessors.50
Private field could be made final. It is only initialized in the declaration or constructor.56
Found non-transient, non-static member. Please mark as transient or provide accessors.56
Found non-transient, non-static member. Please mark as transient or provide accessors.59
No need to check for null before an instanceof105

net/sourceforge/servletspy/handler/std/DebugHandler.java

ViolationLine
Document empty method43 - 44
Document empty method49 - 50
A signature (constructor or method) shouldn't have Exception in throws declaration55

net/sourceforge/servletspy/handler/std/CycleDetectorHandler.java

ViolationLine
Document empty method42 - 43
Document empty method50 - 51
Unnecessary final modifier in final class58 - 60
A signature (constructor or method) shouldn't have Exception in throws declaration58
A catch statement should never catch throwable since it includes errors73

net/sourceforge/servletspy/handler/std/NullHandler.java

ViolationLine
Document empty method35 - 36
Document empty method41 - 42
A signature (constructor or method) shouldn't have Exception in throws declaration47

net/sourceforge/servletspy/handler/std/PrimitivesHandler.java

ViolationLine
Document empty method50 - 51
Document empty method56 - 57
A signature (constructor or method) shouldn't have Exception in throws declaration62

net/sourceforge/servletspy/handler/base/AbstractHandler.java

ViolationLine
Document empty method37 - 38
A signature (constructor or method) shouldn't have Exception in throws declaration45
Document empty method54 - 55

net/sourceforge/servletspy/handler/base/AbstractInterfaceTransformer.java

ViolationLine
This abstract class does not have any abstract methods41 - 170
This call to Collection.toArray() may be optimizable63
Found non-transient, non-static member. Please mark as transient or provide accessors.86
Document empty constructor91 - 92
A signature (constructor or method) shouldn't have Exception in throws declaration119
A signature (constructor or method) shouldn't have Exception in throws declaration133

net/sourceforge/servletspy/handler/base/AbstractClassFilter.java

ViolationLine
Found non-transient, non-static member. Please mark as transient or provide accessors.92
Deeply nested if..then statements are hard to read117 - 119
Document empty method128 - 129
A signature (constructor or method) shouldn't have Exception in throws declaration134

net/sourceforge/servletspy/handler/servlet/SessionContextHandler.java

ViolationLine
Document empty method59 - 60
A signature (constructor or method) shouldn't have Exception in throws declaration83
Document empty method111 - 112

net/sourceforge/servletspy/handler/servlet/PageContextHandler.java

ViolationLine
Document empty method59 - 60
A signature (constructor or method) shouldn't have Exception in throws declaration65
Document empty method85 - 86

net/sourceforge/servletspy/handler/servlet/RequestHandler.java

ViolationLine
A catch statement should never catch throwable since it includes errors113
Document empty method188 - 189
A signature (constructor or method) shouldn't have Exception in throws declaration195
Document empty method231 - 232

net/sourceforge/servletspy/handler/servlet/ServletContextHandler.java

ViolationLine
A signature (constructor or method) shouldn't have Exception in throws declaration54
Document empty method109 - 110
Document empty method115 - 116

net/sourceforge/servletspy/handler/container/ArrayTransformer.java

ViolationLine
Found non-transient, non-static member. Please mark as transient or provide accessors.38
A signature (constructor or method) shouldn't have Exception in throws declaration44
Document empty method80 - 81
Avoid empty catch blocks93 - 94

net/sourceforge/servletspy/handler/container/MapTransformer.java

ViolationLine
Found non-transient, non-static member. Please mark as transient or provide accessors.41
A signature (constructor or method) shouldn't have Exception in throws declaration55
Document empty method97 - 98
Avoid empty catch blocks111 - 112

net/sourceforge/servletspy/handler/container/DynamicProxyTransformer.java

ViolationLine
The class 'DynamicProxyTransformer' has a Cyclomatic Complexity of 5 (Highest = 10).41 - 129
Found non-transient, non-static member. Please mark as transient or provide accessors.44
Document empty constructor49 - 50
Unnecessary final modifier in final class55 - 107
The method 'handle' has a Cyclomatic Complexity of 10.55 - 107
A signature (constructor or method) shouldn't have Exception in throws declaration55
The user-supplied array 'params' is stored directly114
The user-supplied array 'params' is stored directly114
The user-supplied array 'params' is stored directly114

net/sourceforge/servletspy/handler/container/ListTransformer.java

ViolationLine
Found non-transient, non-static member. Please mark as transient or provide accessors.40
A signature (constructor or method) shouldn't have Exception in throws declaration46
Avoid empty catch blocks94 - 95
Document empty method108 - 109

net/sourceforge/servletspy/handler/container/BeanTransformer.java

ViolationLine
A signature (constructor or method) shouldn't have Exception in throws declaration39

net/sourceforge/servletspy/handler/filter/PackageFilter.java

ViolationLine
Avoid protected fields in a final class. Change to private or package access.55
Found non-transient, non-static member. Please mark as transient or provide accessors.55
Document empty constructor60 - 61
Document empty method76 - 77
Unnecessary final modifier in final class84 - 107
A signature (constructor or method) shouldn't have Exception in throws declaration84

net/sourceforge/servletspy/handler/struts/StrutsHandler.java

ViolationLine
A signature (constructor or method) shouldn't have Exception in throws declaration46
Document empty method81 - 82
Document empty method89 - 90

net/sourceforge/servletspy/writer/HtmlNodeWriter.java

ViolationLine
Found non-transient, non-static member. Please mark as transient or provide accessors.45
Avoid throwing null pointer exceptions80
Found non-transient, non-static member. Please mark as transient or provide accessors.100
Found non-transient, non-static member. Please mark as transient or provide accessors.102
Avoid reassigning parameters such as 'counter'181
Avoid reassigning parameters such as 'counter'181
Avoid reassigning parameters such as 'counter'181
Avoid reassigning parameters such as 'counter'181
Avoid reassigning parameters such as 'counter'181
Avoid reassigning parameters such as 'counter'181